Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom fuel #3

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat: custom fuel #3

wants to merge 3 commits into from

Conversation

oz2010
Copy link

@oz2010 oz2010 commented Sep 26, 2022

No description provided.

@nakajimayoshi
Copy link
Member

Hey there! Don't forget to add a prefix to your PR as well as as a description and to convert it to a draft if it's still in progress

@oz2010 oz2010 marked this pull request as draft October 22, 2022 07:54
@oz2010
Copy link
Author

oz2010 commented Oct 22, 2022

Create files and structure for FQIS and its equipment. No computation or logic is being done, just component setup

@oz2010 oz2010 changed the title start of custom fuel feat: custom fuel Oct 22, 2022
nakajimayoshi
nakajimayoshi approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@nakajimayoshi nakajimayoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't be afraid to be verbose in file/class/var names. So instead of "CCS"-> Common Core System, FQIS-> Fuel Quantity Indicating System, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nakajimayoshi nakajimayoshi nakajimayoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oz2010 @nakajimayoshi